Update compliance framework label instances to use GlLabel style
Proposal
With !64283 (merged) we have created a shared Vue component which uses GlLabel
. The existing compliance framework labels are using a customised variant of .badge
. We should update the existing HAML usage to follow GlLabel
as well.
Sizes
Instance | Size | Full | Close-up |
---|---|---|---|
Dashboard (Vue shared) | sm |
||
Compliance frameworks list (Using standard GlLabel currently) |
default |
||
Projects list | default |
||
Projects page | default |
Implementation plan
frontend -
- Update
ee/app/views/compliance_management/compliance_framework/_compliance_framework_badge.html.haml
to use the same styles asGlLabel
- Remove
.compliance-framework-pill
- Update
ee/spec/views/compliance_management/compliance_framework/_compliance_framework_badge.html.haml_spec.rb
spec - Update
ee/app/assets/javascripts/groups/settings/compliance_frameworks/components/list_item.vue
to useee/app/assets/javascripts/vue_shared/components/compliance_framework_label/compliance_framework_label.vue
- Update
ee/spec/frontend/groups/settings/compliance_frameworks/components/list_item_spec.js
spec
Edited by Dennis Tang