Using `Rebase` button on UI leaves out commits from webhook JSON

Summary

When clicking the UI button Rebase, with a webhook configured, the webhook JSON content has no commits.

Steps to reproduce

  1. Configure webhook with Push Events, and Merge Request Events
  2. Open a merge request
  3. Make sure it's behind master
  4. Click Rebase

What is the current bug behavior?

JSON blob sent is missing commits.

What is the expected correct behavior?

JSON blob should contain commits relevant to the merge request

Relevant logs and/or screenshots

JavaScript Object Notation: application/json
    Object
        Member Key: "object_kind"
            String value: push
        Member Key: "event_name"
            String value: push
        Member Key: "before"
            String value: d6a9cca6caae3f868ca905e079c68e638dcc0c10
        Member Key: "after"
            String value: 9af50fbe0e1a7cb572cfa4a326a0862e12e861e1
        Member Key: "ref"
            String value: refs/heads/zstd
        Member Key: "checkout_sha"
            String value: 9af50fbe0e1a7cb572cfa4a326a0862e12e861e1
        Member Key: "message"
            Null value
        Member Key: "user_id"
            Number value: 20
        Member Key: "user_name"
            String value: Aki Tuomi
        Member Key: "user_username"
            String value: aki.tuomi
        Member Key: "user_email"
            String value: aki.tuomi
        Member Key: "user_avatar"
            String value: /uploads/-/system/user/avatar/20/Aki-gw.jpg
        Member Key: "project_id"
            Number value: 11
        Member Key: "project"
            Object
                Member Key: "name"
                    String value: core
                Member Key: "description"
                    String value: 
                Member Key: "web_url"
                    String value: https://git/group/project
                Member Key: "avatar_url"
                    String value: /uploads/-/system/project/avatar/11/dovecot-avatar.png
                Member Key: "git_ssh_url"
                    String value: git@git:group/project.git
                Member Key: "git_http_url"
                    String value: https://git/group/project.git
                Member Key: "namespace"
                    String value: group
                Member Key: "visibility_level"
                    Number value: 10
                Member Key: "path_with_namespace"
                    String value: group_project
                Member Key: "default_branch"
                    String value: master
                Member Key: "ci_config_path"
                    Null value
                Member Key: "homepage"
                    String value: https://git/group/project
                Member Key: "url"
                    String value: git@git:group/project.git
                Member Key: "ssh_url"
                    String value: git@git:group/project.git
                Member Key: "http_url"
                    String value: https://git/group/project.git
        Member Key: "commits"
            Array
        Member Key: "total_commits_count"
            Number value: 0
        Member Key: "repository"
            Object
                Member Key: "name"
                    String value: core
                Member Key: "url"
                    String value: git@git:group/project.git
                Member Key: "description"
                    String value: 
                Member Key: "homepage"
                    String value: https://git/group/project
                Member Key: "git_http_url"
                    String value: https://git/group/project.git
                Member Key: "git_ssh_url"
                    String value: git@git:group/project.git
                Member Key: "visibility_level"
                    Number value: 10

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Debian 8.9
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.3.3p222
Gem Version:	2.6.6
Bundler Version:1.13.7
Rake Version:	10.5.0
Redis Version:	3.2.5
Git Version:	2.13.4
Sidekiq Version:5.0.0
Go Version:	unknown

GitLab information
Version:	9.4.4-ee
Revision:	c7bc62c
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
DB Version:	9.6.3
URL:		https://git
HTTP Clone URL:	https://git/some-group/some-project.git
SSH Clone URL:	git@git:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	yes
Using Omniauth:	no


GitLab Shell
Version:	5.3.1
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...

GitLab Shell version >= 5.3.1 ? ... OK (5.3.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
11/5 ... ok
11/6 ... ok
9/7 ... ok
9/8 ... ok
10/9 ... ok
10/10 ... ok
10/11 ... ok
11/12 ... ok
4/15 ... ok
4/16 ... ok
10/17 ... ok
10/18 ... ok
10/19 ... ok
10/20 ... ok
10/21 ... ok
10/22 ... ok
10/23 ... ok
4/24 ... ok
12/25 ... ok
10/26 ... ok
18/30 ... ok
8/33 ... ok
10/35 ... ok
5/36 ... ok
5/37 ... ok
4/39 ... ok
4/47 ... ok
8/48 ... ok
10/49 ... ok
8/50 ... ok
12/51 ... ok
8/52 ... ok
10/53 ... ok
13/54 ... ok
5/55 ... ok
5/56 ... ok
10/57 ... ok
10/58 ... ok
4/59 ... ok
10/60 ... ok
8/61 ... ok
10/62 ... ok
20/63 ... ok
5/64 ... ok
13/65 ... ok
14/66 ... ok
20/68 ... ok
9/70 ... ok
4/71 ... ok
10/72 ... ok
9/74 ... ok
5/76 ... ok
5/78 ... ok
5/79 ... ok
15/80 ... ok
15/81 ... ok
15/82 ... ok
5/83 ... ok
4/84 ... ok
4/85 ... ok
5/86 ... ok
11/87 ... ok
10/88 ... ok
25/89 ... ok
25/90 ... ok
26/91 ... ok
26/92 ... ok
26/93 ... ok
26/94 ... ok
16/95 ... ok
16/96 ... ok
8/97 ... ok
25/98 ... ok
9/99 ... ok
16/100 ... ok
8/101 ... ok
16/102 ... ok
8/103 ... ok
16/104 ... ok
22/105 ... ok
14/106 ... ok
10/107 ... ok
7/108 ... ok
16/109 ... ok
27/110 ... ok
27/111 ... ok
9/112 ... ok
27/113 ... ok
16/114 ... ok
16/115 ... ok
16/116 ... ok
27/117 ... ok
8/118 ... ok
25/119 ... ok
12/120 ... ok
25/121 ... ok
5/122 ... ok
16/123 ... ok
25/124 ... ok
14/125 ... ok
10/127 ... ok
31/129 ... ok
31/130 ... ok
5/131 ... ok
4/132 ... ok
33/133 ... ok
14/135 ... ok
32/136 ... ok
32/137 ... ok
32/138 ... ok
32/139 ... ok
32/140 ... ok
26/141 ... ok
32/144 ... ok
32/145 ... ok
25/146 ... ok
5/147 ... ok
5/149 ... ok
10/150 ... ok
16/153 ... ok
16/154 ... ok
32/155 ... ok
33/157 ... ok
16/158 ... ok
9/159 ... ok
16/160 ... ok
16/161 ... ok
32/162 ... ok
32/163 ... ok
16/164 ... ok
16/165 ... ok
16/166 ... ok
16/167 ... ok
33/168 ... ok
32/169 ... ok
33/170 ... ok
35/171 ... ok
14/172 ... ok
22/174 ... ok
32/175 ... ok
10/176 ... ok
7/177 ... ok
7/178 ... ok
14/180 ... ok
16/184 ... ok
5/185 ... ok
7/186 ... ok
16/187 ... ok
5/188 ... ok
13/189 ... ok
9/190 ... ok
38/191 ... ok
37/196 ... ok
37/198 ... ok
16/202 ... ok
32/205 ... ok
32/206 ... ok
37/207 ... ok
37/208 ... ok
14/209 ... ok
32/210 ... ok
40/211 ... ok
25/212 ... ok
14/213 ... ok
32/214 ... ok
13/215 ... ok
16/216 ... ok
16/217 ... ok
14/218 ... ok
10/219 ... ok
14/220 ... ok
25/221 ... ok
40/222 ... ok
9/223 ... ok
13/224 ... ok
40/225 ... ok
16/226 ... ok
34/227 ... ok
16/228 ... ok
16/230 ... ok
43/231 ... ok
43/233 ... ok
12/234 ... ok
43/236 ... ok
12/238 ... ok
9/239 ... ok
43/240 ... ok
11/242 ... ok
34/243 ... ok
34/244 ... ok
10/245 ... ok
16/246 ... ok
9/247 ... ok
40/248 ... ok
41/249 ... ok
32/250 ... ok
30/251 ... ok
32/252 ... ok
46/253 ... ok
46/254 ... ok
43/255 ... ok
32/256 ... ok
16/257 ... ok
16/258 ... ok
16/259 ... ok
32/260 ... ok
32/261 ... ok
43/262 ... ok
32/263 ... ok
10/264 ... ok
14/265 ... ok
32/267 ... ok
50/268 ... ok
37/269 ... ok
32/270 ... ok
32/271 ... ok
9/272 ... ok
10/273 ... ok
16/274 ... ok
16/275 ... ok
32/276 ... ok
12/277 ... ok
6/278 ... ok
5/279 ... ok
10/280 ... ok
9/281 ... ok
5/282 ... ok
32/283 ... ok
32/284 ... ok
43/285 ... ok
5/286 ... ok
43/287 ... ok
16/288 ... ok
16/289 ... ok
43/290 ... ok
52/291 ... ok
9/292 ... ok
35/293 ... ok
5/294 ... ok
10/297 ... ok
16/298 ... ok
40/299 ... ok
32/300 ... ok
35/302 ... ok
16/303 ... ok
35/304 ... ok
32/305 ... ok
32/306 ... ok
32/307 ... ok
52/308 ... ok
55/310 ... ok
55/311 ... ok
35/313 ... ok
32/314 ... ok
16/315 ... ok
16/316 ... ok
16/317 ... ok
6/318 ... ok
40/319 ... ok
40/320 ... ok
53/321 ... ok
50/322 ... ok
43/323 ... ok
43/324 ... ok
52/325 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Reply by email ...


Reply by email is disabled in config/gitlab.yml


Checking Reply by email ... Finished


Checking LDAP ...


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
11/5 ... yes
11/6 ... yes
9/7 ... yes
9/8 ... yes
10/9 ... yes
10/10 ... yes
10/11 ... yes
11/12 ... yes
4/15 ... yes
4/16 ... yes
10/17 ... yes
10/18 ... yes
10/19 ... yes
10/20 ... yes
10/21 ... yes
10/22 ... yes
10/23 ... yes
4/24 ... yes
12/25 ... yes
10/26 ... yes
18/30 ... yes
8/33 ... yes
10/35 ... yes
5/36 ... yes
5/37 ... yes
4/39 ... yes
4/47 ... yes
8/48 ... yes
10/49 ... yes
8/50 ... yes
12/51 ... yes
8/52 ... yes
10/53 ... yes
13/54 ... yes
5/55 ... yes
5/56 ... yes
10/57 ... yes
10/58 ... yes
4/59 ... yes
10/60 ... yes
8/61 ... yes
10/62 ... yes
20/63 ... yes
5/64 ... yes
13/65 ... yes
14/66 ... yes
20/68 ... yes
9/70 ... yes
4/71 ... yes
10/72 ... yes
9/74 ... yes
5/76 ... yes
5/78 ... yes
5/79 ... yes
15/80 ... yes
15/81 ... yes
15/82 ... yes
5/83 ... yes
4/84 ... yes
4/85 ... yes
5/86 ... yes
11/87 ... yes
10/88 ... yes
25/89 ... yes
25/90 ... yes
26/91 ... yes
26/92 ... yes
26/93 ... yes
26/94 ... yes
16/95 ... yes
16/96 ... yes
8/97 ... yes
25/98 ... yes
9/99 ... yes
16/100 ... yes
8/101 ... yes
16/102 ... yes
8/103 ... yes
16/104 ... yes
22/105 ... yes
14/106 ... yes
10/107 ... yes
7/108 ... yes
16/109 ... yes
27/110 ... yes
27/111 ... yes
9/112 ... yes
27/113 ... yes
16/114 ... yes
16/115 ... yes
16/116 ... yes
27/117 ... yes
8/118 ... yes
25/119 ... yes
12/120 ... yes
25/121 ... yes
5/122 ... yes
16/123 ... yes
25/124 ... yes
14/125 ... yes
10/127 ... yes
31/129 ... yes
31/130 ... yes
5/131 ... yes
4/132 ... yes
33/133 ... yes
14/135 ... yes
32/136 ... yes
32/137 ... yes
32/138 ... yes
32/139 ... yes
32/140 ... yes
26/141 ... yes
32/144 ... yes
32/145 ... yes
25/146 ... yes
5/147 ... yes
5/149 ... yes
10/150 ... yes
16/153 ... yes
16/154 ... yes
32/155 ... yes
33/157 ... yes
16/158 ... yes
9/159 ... yes
16/160 ... yes
16/161 ... yes
32/162 ... yes
32/163 ... yes
16/164 ... yes
16/165 ... yes
16/166 ... yes
16/167 ... yes
33/168 ... yes
32/169 ... yes
33/170 ... yes
35/171 ... yes
14/172 ... yes
22/174 ... yes
32/175 ... yes
10/176 ... yes
7/177 ... yes
7/178 ... yes
14/180 ... yes
16/184 ... yes
5/185 ... yes
7/186 ... yes
16/187 ... yes
5/188 ... yes
13/189 ... yes
9/190 ... yes
38/191 ... yes
37/196 ... yes
37/198 ... yes
16/202 ... yes
32/205 ... yes
32/206 ... yes
37/207 ... yes
37/208 ... yes
14/209 ... yes
32/210 ... yes
40/211 ... yes
25/212 ... yes
14/213 ... yes
32/214 ... yes
13/215 ... yes
16/216 ... yes
16/217 ... yes
14/218 ... yes
10/219 ... yes
14/220 ... yes
25/221 ... yes
40/222 ... yes
9/223 ... yes
13/224 ... yes
40/225 ... yes
16/226 ... yes
34/227 ... yes
16/228 ... yes
16/230 ... yes
43/231 ... yes
43/233 ... yes
12/234 ... yes
43/236 ... yes
12/238 ... yes
9/239 ... yes
43/240 ... yes
11/242 ... yes
34/243 ... yes
34/244 ... yes
10/245 ... yes
16/246 ... yes
9/247 ... yes
40/248 ... yes
41/249 ... yes
32/250 ... yes
30/251 ... yes
32/252 ... yes
46/253 ... yes
46/254 ... yes
43/255 ... yes
32/256 ... yes
16/257 ... yes
16/258 ... yes
16/259 ... yes
32/260 ... yes
32/261 ... yes
43/262 ... yes
32/263 ... yes
10/264 ... yes
14/265 ... yes
32/267 ... yes
50/268 ... yes
37/269 ... yes
32/270 ... yes
32/271 ... yes
9/272 ... yes
10/273 ... yes
16/274 ... yes
16/275 ... yes
32/276 ... yes
12/277 ... yes
6/278 ... yes
5/279 ... yes
10/280 ... yes
9/281 ... yes
5/282 ... yes
32/283 ... yes
32/284 ... yes
43/285 ... yes
5/286 ... yes
43/287 ... yes
16/288 ... yes
16/289 ... yes
43/290 ... yes
52/291 ... yes
9/292 ... yes
35/293 ... yes
5/294 ... yes
10/297 ... yes
16/298 ... yes
40/299 ... yes
32/300 ... yes
35/302 ... yes
16/303 ... yes
35/304 ... yes
32/305 ... yes
32/306 ... yes
32/307 ... yes
52/308 ... yes
55/310 ... yes
55/311 ... yes
35/313 ... yes
32/314 ... yes
16/315 ... yes
16/316 ... yes
16/317 ... yes
6/318 ... yes
40/319 ... yes
40/320 ... yes
53/321 ... yes
50/322 ... yes
43/323 ... yes
43/324 ... yes
52/325 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.3)
Git version >= 2.7.3 ? ... yes (2.13.4)
Active users: ... 36
Elasticsearch version 5.1 - 5.3? ... skipped (elasticsearch is disabled)


Checking GitLab ... Finished