Fix terraform wrong use of `GroupPackagesFinder`
Summary
The terraform API class uses GroupPackagesFinder
in a wrong way.
It passes a package name but actually the finder is doing a fuzzy search.
This could lead to ~bugs where package foobar
is returned when package name foo
is used.
Solution
Use a custom finder to find the package by exact name or implement #333790 and use that.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- David Fernandez changed milestone to %Backlog
changed milestone to %Backlog
- David Fernandez set weight to 1
set weight to 1
- David Fernandez mentioned in merge request !62760 (merged)
mentioned in merge request !62760 (merged)
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 added sectionops label
added sectionops label
- David Fernandez mentioned in issue #340812 (closed)
mentioned in issue #340812 (closed)
- Justin Farmiloe added customer label
added customer label
- Developer
Premium SaaS customer has encountered this bug (ZD link).
Wrong module content is being returned from Infrastructure Registry due to fuzzy search, breaking Terraform plan.
Collapse replies @nagyv-gitlab FYI
- Contributor
I am that customer. We experienced this issue with TF modules we are publishing to GitLab. We were really excited about this feature of GitLab. However, this is a showstopper for us. We won't expand our use of this (or recommend it to others) until this issue is resolved. The problems it has caused us and the potential problems it can continue to cause make it too unreliable to expand the use of it. I really hope this issue gets resolved soon.
- Developer
@jfarmiloe @american_family Thanks for reporting this bug. Thomas, you can see our approach below
Let me know if you have any other feedback around the GitLab Terraform features. I'd love to hear them.
- Developer
I have a GitLab Premium ~"SaaS" customer with 2100 users interested in this.
- Link to request: Internal SFDC
- Link to Ticket: (ZD link).
- Priority: customer priority10
- Why interested: Wrong module content is being returned from Infrastructure Registry due to fuzzy search, breaking Terraform plan.
- Current solution for this problem: None.
- Impact to the customer of not having this: This is a showstopper for them. They won't expand their use of this (or recommend it to others) until this issue is resolved. The problems it has caused us and the potential problems it can continue to cause make it too unreliable to expand the use of it.
- PM to mention: @nagyv-gitlab -- already aware
@mcahill @american_family
1 1 - Developer
@jfarmiloe @shoyle1 Thanks for reporting. We just learned about his bug and try to give it the highest priority as we consider it a severity1 bug.
1 - Developer
Appreciate the update, thank you. I'll keep
on this issue.
- Tim Rizzi added Terraform Registry devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] labels and removed devopspackage grouppackage registry labels
added Terraform Registry devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] labels and removed devopspackage grouppackage registry labels
- Tim Rizzi removed Category:Package Registry label
removed Category:Package Registry label
- Tim Rizzi added Category:Infrastructure as Code label
added Category:Infrastructure as Code label
- Developer
@nicholasklick I applied priority1 severity1 to this bug. Let me know if you disagree. Giving the team capacities, I considered priority2 as well.
1 - Viktor Nagy (GitLab) added candidate14.5 priority1 severity1 labels
added candidate14.5 priority1 severity1 labels
- Developer
- Matt Kasa mentioned in merge request !72043 (merged)
mentioned in merge request !72043 (merged)
- Nick Klick changed milestone to %14.4
changed milestone to %14.4
- Nick Klick assigned to @mattkasa
assigned to @mattkasa
- Nick Klick changed milestone to %14.5
changed milestone to %14.5
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Viktor Nagy (GitLab) added Deliverable label
added Deliverable label
- Developer
@nicholasklick @mattkasa May I ask for an update please? I see two merged MRs. Is the issue fixed?
Collapse replies @nagyv-gitlab Not yet, one more is needed to resolve this issue, I can update on that later today.
1
- Matt Kasa created merge request !73588 (merged) to address this issue
created merge request !73588 (merged) to address this issue
- Matt Kasa mentioned in merge request !73588 (merged)
mentioned in merge request !73588 (merged)
- 🤖 GitLab Bot 🤖 added SLOMissed label
added SLOMissed label
Closing as fixed by !73588 (merged), which should be in %14.5
- Matt Kasa closed
closed
- David Fernandez mentioned in issue #333790
mentioned in issue #333790
- 🤖 GitLab Bot 🤖 added groupenvironments label and removed groupconfigure [DEPRECATED] label
added groupenvironments label and removed groupconfigure [DEPRECATED] label