Search on navbar has multiple technical debts

Summary

Global search on navbar has a lot of technical debts in frontend. e.g., deep nesting, unused HTML snippets etc. Most technical debts were introduced in gitlab-foss!3212 (merged) in %8.7 and have been left untouched since the author/reviewer @asumaran @jschatz1 have been not in the Team for a while.

Steps to reproduce

Use global search.

What is the current bug behavior?

TBA

What is the expected correct behavior?

TBA

Relevant logs and/or screenshots

See some from previously merged MRs gitlab-foss!3212 (merged) etc.

Output of checks

This bug happened on GitLab.com as of %14.0 through %14.10 but does not any more on %14.10 and later.

TODO after %15.0

• Remove app/views/layouts/_search.html.haml
• Remove loadHTMLFixture of 'static/search_autocomplete.html'

added Category:Global Search UI component UI polish advanced search basic search frontend groupglobal search typebug labels

changed the description

added bugperformance maintenancerefactor labels

added product intelligence label

mentioned in merge request !63936 (closed)

added CSS cleanup CSS refactor labels

assigned to @tnir

changed milestone to %14.0

changed due date to June 19, 2021

Setting label(s) devopsenablement sectionenablement based on groupglobal search.

added devopssystems sectioncore platform labels

It's unlikely the fix will make into %14.0 so I move it to %14.1

changed milestone to %14.1

@tnir I saw the MR is very close to ready. I wanted to see if we think this was something that would line up for 14.1 (MR complete by 15th).

We can always move this to 14.2 if we need more time.

Thank you for your contribution!

@JohnMcGuire Thanks for reminding me. !63936 (closed) as of now has the merge conflicts so I need to fix it to get it merged soon.

added typemaintenance label

removed typebug label

added typefeature label

added workflowin review label

changed milestone to %14.2

Moving into 14.3 to continue working.

changed milestone to %14.3

changed milestone to %14.4

Moving into the backlog until we there is time to work on it. @tnir Please ping me when it's ready to be worked on and I will move it into the active milestone.

Thanks for your contributions.

changed milestone to %Backlog

removed typefeature label

added severity4 label

added 1 deleted label

added devopsdata stores label and removed devopssystems label

marked this issue as related to #339348 (closed)

changed the description

changed milestone to %15.1

added workflowstart label and removed workflowin review label

@tnir we don't use label workflowstart in our planning and development process. Once we move an issue to a milestone, we use workflowready for development to indicate that someone can start working on that issue. Once it's under development, we use workflowin dev.

Got it!

added workflowready for development label and removed workflowstart label

changed due date to July 05, 2022

changed milestone to %15.2

mentioned in issue gitlab-org/quality/triage-reports#8047 (closed)

mentioned in issue gitlab-org/quality/triage-reports#8145 (closed)

mentioned in issue gitlab-org/quality/triage-reports#8230 (closed)

changed milestone to %Backlog

added workflowscheduling label and removed workflowready for development label

added Deliverable label

changed milestone to %15.3

changed milestone to %Backlog

removed Deliverable label

@tbulva

Did we need this in 15.3? I would like to leave it in the backlog until we hear from @tnir or until we need it.

Hi @JohnMcGuire, this is about removing old code... I'd like to pick this up when we remove the feature flag for the header search.

changed milestone to %15.3

I have to move this issue to %Backlog again. As I understand, we will be able to address this issue when we come to #339348 (closed). We will schedule this issue when we work on #339348 (closed).

changed milestone to %Backlog

@tnir, the files mentioned in the description are no longer there after rounds of changes. I am closing this issue for now. Let us know if you see issues.

closed