Handle remaining of Usage Ping metrics from `license_management` to `license_scanning
In %13.0 we dropped support of license_management scanning job, as we renamed it to license_scanning. Still, all metrics are named license_managenent to simplify the naming transition. Now it's time to change this name as well
Proposal
Drop support for any metrics emitted with a license_management key.
Implementation plan
-
update usage_data.rb -
update to remove license_managementfromSECURE_PRODUCT_TYPES: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/lib/ee/gitlab/usage_data.rb#L30-32 -
update to switch from license_management_jobskey tolicense_scanning_jobsinsecurity_products_usage: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/lib/ee/gitlab/usage_data.rb#L152 -
update to use a single key rather than a combined license key: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/lib/ee/gitlab/usage_data.rb#L385-388 -
update ee/spec/usage_data to reflect changes above: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/spec/lib/ee/gitlab/usage_data_spec.rb
-
-
update ee/config/metrics/**/*.yml -
for each file in { ee/config/metrics/counts_all/20210216175218_user_license_management_jobs.yml,ee/config/metrics/counts_28d/20210216175224_user_license_management_jobs.yml,ee/config/metrics/counts_all/20210204124854_license_management_jobs.yml}
-
Edited by Igor Frenkel