Follow-up from "Handle enter action of MR comment form"
The following discussion from !62376 (merged) should be addressed:
-
@mrincon started a discussion: (+1 comment) Suggestion (non-blocking): Ideally our tests should not test the internals of the component:
if you are checking a
wrapper.vm
property, you should probably stop and rethink the test to check the rendered template insteadFrom: https://docs.gitlab.com/ee/development/testing_guide/frontend_testing.html#dont-test-the-library
In this specific case, we should check that the draft got saved by Vuex (the Vuex action
saveNote
was called).I see these tests were already like this so I don't think this is a blocker.
👍