System Note should say "added weight" instead of "changed weight" when none was previously set

Problem to solve

When adding a weight to an issue that previously had no weight the system note reads @theoretick changed weight to 5 just now when it should say @theoretick added weight of 5 just now. This is more intuitive and reflects usage of labels and other attributes

Intended users

  • Parker (Product Manager)
  • Delaney (Development Team Lead)
  • Sasha (Software Developer)
  • Presley (Product Designer)

Further details

Example of adding weight when none existed previously

Image_2019-10-02_at_08.45.15

Proposal

Change language of system note to say "Added" instead of "changed" when there was no weight previously"

Permissions and Security

No change to permissiosn

Documentation

No change to docs

Testing

What does success look like, and how can we measure that?

System notes more clearly articulate the previous state of the issue.

What is the type of buyer?

GitLab Starter

Links / references

  • Relevant LoC: https://gitlab.com/gitlab-org/gitlab/blob/621e0b184f0c26bbac40abdf1ce22c2560725817/ee/app/services/ee/system_note_service.rb#L177
Edited Sep 02, 2020 by 🤖 GitLab Bot 🤖
Assignee Loading
Time tracking Loading