Lock project MR approval settings when group settings are enforced
Why are we doing this work
At the moment, group-level MR approval settings do not have any effect on the project-level counterparts. Once the backend API is implemented, the UI should reflect this enforcement in the settings.
Relevant links
- Backend issue (#325620 (closed))
Non-functional requirements
-
Documentation: Update the doc, including screenshots if possible -
Feature flag: Ensure this feature is behind group_merge_request_approval_settings_feature_flag
-
Performance: -
Testing: Add feature/UI tests
Implementation plan
frontend weight
- Update the approval mappers to always output object based settings
- Update
ApprovalSettings
to consume object format settings - Update
ApprovalSettingsCheckbox
to display locked and locked text depending on where the rule was enforced - Update the project settings to use the new endpoint when the feature flag is enabled
- Update specs
Edited by Jiaan Louw