Pipeline failure email contains broken link to merge request ref

Summary

The pipeline failure email notification contains a link to a Branch with a ref but when the pipeline is for a merge request (detached) it does not point directly to a branch but an internal merge request ref.

image

Issues observed:

  1. The Branch field shows a ref that is not a branch (perhaps this needs to be renamed to Ref?)
  2. clicking on the ref link brings to a 404 (as expected, because the ref is internal)

Steps to reproduce

Open a merge request and have a failing pipeline. You should see a similar email notification.

What is the current bug behavior?

Broken link and invalid branch ref

What is the expected correct behavior?

  • The Branch should show the source branch of the merge request (not the ref)
  • The link should bring to the source branch

This in effectively a regression because it used to show the branch for merge request pipelines:

image