Skip to content

Pipeline editor visualization lines are not redrawn when editing the config

Summary

When you are in the pipeline editor, you can write your configuration and then click on visualize to see it what it will look like. This bug is that when you update your CI config and then go to visualize, the links will have disappeared.

Steps to reproduce

  • Navigate to CI/CD => Editor
  • Click on Visualize tab
  • Notice all the links are visible
  • Edit your configuration
  • Go to the visualize tab
  • Notice that the links are gone

Note that if you edit your configuration before changing tab the first time, it will work, so the issue really only starts after you have seen the visualization once (so the Vue component has mounted once already)

Example Project

https://gitlab.com/gitlab-org/gitlab/-/ci/editor

What is the current bug behavior?

The visualization lines disappear

What is the expected correct behavior?

The lines are updated with the new config

Relevant logs and/or screenshots

Screen_Recording_2021-05-20_at_2.45.42_PM

Output of checks

This bug happens on GitLab.com

Possible fixes

Check app/assets/javascripts/pipelines/components/graph_shared/links_layer.vue component in the prepareLinkData method. We change when we call this so it's possible that when app/assets/javascripts/pipelines/components/pipeline_graph/pipeline_graph.vue mounts the first time, it calls everything properly, but after a change it doesn't