Indefinite pipeline when using manual job with "needs:" for another manual job

While trying to workaround problems with manual jobs ignoring other manual job dependencies: #32552, I noticed a problem with the needs keyword:

CI configuration without needs

stages:
  - build
  - test
  - deploy

BuildJob:
  stage: build
  tags:
    - docker
  script:
    - echo "building"
    
TestJob-manual:
  stage: test
  when: manual
  tags:
    - docker
  script:
    - echo "testing"

DeployJob-manual:
  when: manual
  dependencies:
    - TestJob-manual
  stage: deploy
  tags:
    - docker
  script:
    - echo "deploying"

This is how the finished pipeline looks like: "passed", so everything is OK. Just as a side note: see how the play button is available for the deploy job but this is the mentioned other bug (#32552)

CI configuration with needs

stages:
  - build
  - test
  - deploy

BuildJob:
  stage: build
  tags:
    - docker
  script:
    - echo "building"
    
TestJob-manual:
  stage: test
  when: manual
  tags:
    - docker
  script:
    - echo "testing"

DeployJob-manual:
  when: manual
  dependencies:
    - TestJob-manual
  needs:
    - TestJob-manual
  stage: deploy
  tags:
    - docker
  script:
    - echo "deploying"

The pipeline now runs indefinitely because the deployment job waits for the testjob to be started manually. This is inconsistent to how dependencies is handled - there, the pipeline passes when the two manual jobs are not started.

If I then manually start the test job, two things happen:

• The pipeline is passed
• The deploy job did not run This is also unexpected

How to reproduce

Use the above CI YAML or see https://gitlab.com/PhilLab/testing-private/

changed the description

mentioned in issue #33196 (closed)

added Category:Continuous Integration devopsverify grouppipeline execution pipeline severity3 typebug labels

mentioned in issue #33512 (closed)

added priority3 label

mentioned in issue #35040 (closed)

We're facing a similar issue. There are test stage, which is fully when: manual, and release stage, which is fully when: on_success and doesn't use needs at all. The problem is that pipeline doesn't run release stage at all waiting on all when: manual jobs despite the fact they have allow_failure: true by default.

mentioned in issue #35493 (closed)

@furkanayhan this seems like a duplicate of #31264 (closed) am I correct? Should we close it?

@steveazz It looks like it is duplicate, thanks!

I am closing it.

@PhilLab If you think it is not duplicate of #31264 (closed), please let us know and reopen this.

closed

marked this issue as related to #31264 (closed)