Clarify compliance framework empty state in groups and subgroups
Problem to solve
The current section description and empty state message can make it appear as though compliance frameworks can be added and managed in subgroups. Since that functionality doesn't exist, there is a need to clarify to set expectations.
Proposal
Differentiate what is displayed for groups and subgroups, and refine some UI text
User role: Owner
Group - Empty | Subgroup - Empty |
---|---|
User role: Maintainer
Group - Empty | Subgroup - Empty |
---|---|
Resources
Implementation plan
- Add
user_can_edit
(permission to edit frameworks),group_path
,group_name
andgroup_type
(root
,subgroup
) tocompliance_frameworks_list_data
inee/app/helpers/compliance_management/compliance_framework/group_settings_helper.rb:10
- Pass new attributes to the app through
ee/app/assets/javascripts/groups/settings/compliance_frameworks/init_list.js:18
usingprovide/inject
- Update
emptyStateSvgPath
to go throughprovide/inject
too - Update
ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb:35
to test the data is being returned - Update
ee/app/assets/javascripts/groups/settings/compliance_frameworks/components/list_empty_state.vue
to show the correct text based upon the user role and group type - Update
ee/spec/frontend/groups/settings/compliance_frameworks/components/list_spec.js
to not pass theemptyStateSvgPath
around - Update
ee/spec/frontend/groups/settings/compliance_frameworks/components/list_empty_state_spec.js
to test the new logic
Edited by Robert Hunt