Security MR Widget "?" icon alignment is off for non-Ultimate users
Summary
For non-Ultimate users, the ?
icon in the Security MR Widget is too close to the text. We have a related bug at #296030 (closed) regarding the ?
icons within approvers section.
Steps to reproduce
This MR widget variant appears when you are a non-admin role on a core/non-Ultimate project.
- Create a non-Ultimate project (easiest way is to create a private project)
- Create an MR that will include security scan results
- Add a member with the Developer role
- Log in as that member and view the MR
Example Project
What is the current bug behavior?
?
icon on Security scans row is spaced too close to the text.
What is the expected correct behavior?
Standard spacing used on other icons should be used.
Relevant logs and/or screenshots
Variant for a non-admin users on a non-Ultimate project (blue ?
with spacing issue)
Variant for an admin user on a non-Ultimate project (white `?' with correct spacing)
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
-
Edit help_icon.vue to use the same icon ( question
) and color (link blue) in the two cases, and add padding as necessary for this case- To test the two cases, follow the set up instructions in !49613 (merged).