Skip to content

Shared filtered search bar does not allow selecting multiple labels

Summary

The shared filtered search component is not allowing the selection of multiple labels, we should be able to select multiple labels if the unique: false property is set on the token.

Steps to reproduce

  1. Navigate to https://gitlab.com/gitlab-org/gitlab/-/analytics/code_reviews
  2. Add a label filter
  3. Attempt to add another one, the loading indicator continues to spin

Example Project

We can see this happening with the filter bars on code review analytics and VSA

This seems to only affect filter bars using the ~/vue_shared/components/filtered_search_bar/store/modules/filters shared vuex module.

What is the current bug behavior?

The selected label seems to be added as a search parameter to the request for labels, since the label is already selected the result is no new labels are returned to be displayed

What is the expected correct behavior?

We should see all the available labels, except for the one currently selected.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

Edited by Ezekiel Kigbo