External Status Checks: Introduce "fail" status
Proposal
After the implementation of making a status 'passed' via an external service, we are going to implement the ability to explicitly 'fail' statuses via the same external service.
Additional:
- Remove the help text from the widget.
- Replace
,with:as a delimeter
Implementation plan
- Introduce a third
statusoption forMergeRequest::StatusCheckResponse:failed. - Modify the API endpoint for
status_check_responsesto accept an optionalstatusparameter. For backward compatibility,statusshould default topassedif not given. (This default will be removed under #338827 (closed))
Original implementation plan
- Add new
succeededattribute toMergeRequest::StatusCheckResponse. There is no default, but it is a required field.- Existing records at this point should all be migrated to be
succeeded: trueto preserve the behaviour of old records.
- Existing records at this point should all be migrated to be
- Add new API endpoint to allow "fail" of status checks. This should be done in a non-breaking change way. Allowing "pass" of a status check should not change.
- Make sure API is exposing status of a status check.
Edited by Dan Jensen
