UpdateRemoteMirrorService doesn't log the status of Lfs::PushService
-
Lfs::PushService
can fail for a number of reasons (e.g. invalid credentials), but the exception is quietly swallowed in https://gitlab.com/gitlab-org/gitlab/blob/cad4514fa50fa058aba5602ab6ec53219d535fa2/app/services/lfs/push_service.rb#L19-21. -
UpdateRemoteMirrorService#send_lfs_objects!
doesn't check the return value or log it anywhere: https://gitlab.com/gitlab-org/gitlab/blob/8c30dc7e05fa38770e7a6094cd48f1050dc123c2/app/services/projects/update_remote_mirror_service.rb#L67-72
We should probably log an error somewhere, preferably in the mirror error output to show this happened.
Edited by Ash McKenzie