Can't override approvers and approvals required per merge request

Summary

We can't override the approvers from merge request with the option enabled on settings. If you have 2 required approvals and you edit to 0 or 1, the approvals still on 2 after save settings.

Steps to reproduce

• Create a new project
• Enable the project's Merge Request approvals setting
• Set a project-level approval number of 2
• Create a new Merge Request
• In the create form change the required number of approvals to 1

Example Project

N/A

What is the current bug behavior?

Upon creating the new Merge Request the project level default is inherited

What is the expected correct behavior?

The Merge Request specific approver number is accepted

Relevant logs and/or screenshots

Screen gifs:

https://drive.google.com/file/d/0B95wBRL3BhgKX3pBRTVnTGo3RHc/view?usp=sharing https://drive.google.com/file/d/0B95wBRL3BhgKZERGV0ZMYldjejg/view?usp=sharing https://drive.google.com/file/d/0B95wBRL3BhgKd0Y5NklrUVB2blk/view?usp=sharing

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

N/A reproduced on GitLab.com v9.5.2-ee

Results of GitLab application Check

N/A reproduced on GitLab.com v9.5.2-ee

Possible fixes