It looks like our app is affected because we are using JWT authentication. We do verify the qsh claim but we should still follow the steps described here.
Setting priority2 because the change will be enforced by Jun 7, 2021.
@Andysoiron@mnohr I wonder if we should also backport this change, to reduce the breakage for users on older GitLab versions. I guess technically we could treat it as a security fix, except that the vulnerability was on the Jira side rather than GitLab.
@toupeira I think we may need to do that. If we make the change in %14.0, then customers will not get the fix until mid-June. That only gives customers a couple of weeks until this is enforced.
Atlassian has introduced a breaking change that will be enforced on June 7, 2021. This date is after we are able to implement and release the fix (%14.0, June 22).
@.luke yes as far as I understand the description from Atlassian this is all we need to do. In addition to that we should do some testing to make sure it still works
We should test the opt-in (context-qsh: true) and there are basically two possible outcomes from that:
We do already verify the qsh correctly, then we don't need to do anything because on June 7th they will flip the switch and we do not need to backport anything to older releases.
We do not verify the qsh correctly and need to make code changes: Ouch, we need to fix it ASAP and run through backports.
Personally I think we might not do anything for those local installs, because according to the docs, they will just enforce the new behavior starting June 7th. As we do not need any changes in our code base for functionality, existing local installs should still work.
Enforcement of this breaking change is planned for all apps by Jun 7, 2021. If you do not patch your app to mitigate this vulnerability and opt-in to the context-qsh API migration before this date, your app may stop working.
If we really want to push the opt-in to self-managed, we could use Pick into 13.12 rather than backporting it to all the releases.
Discussed this in Slack, and backporting to the last 3 releases seems more sensible from the Atlassian blog post:
This vulnerability affects apps regardless of how they are installed; apps listed on the Marketplace and apps installed via the UPM “dev mode” are affected .
If your app does not use context JWTs (see below), you must still opt-in to the breaking changes as soon as possible.
After discussing this on Slack, we have decided that the backports are needed so we will go with the standard security process, #328267 (comment 573473644).
If you are using Jira Connect with a self-managed instance you need to update to these latest security releases before June 7th. If you are on GitLab.com, you do not need to do anything. For more details see