[FE] Add form validation of required customer profile form fields
Add form validation of required customer profile form fields.
First we calculate the user count by looking at the selected users (in the subscription case) and fallback to numberOfUsers
on the group if that is not available (CI Minutes, Storage, etc.):
const userCount = numberOfUsersModel || selectedGroup.numberOfUsers
- For user count === 1
- Required:
first_name
,last_name
- Optional:
organization
,company_size
- Required:
- For user count > 1
- Required:
first_name
,last_name
,organization
,company_size
,
- Required:
See details in the Epic: &5785 (closed)
Designs
- Show closed items
Is blocked by
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Michael Lunøe added to epic &5785 (closed)
added to epic &5785 (closed)
- Michael Lunøe set weight to 2
set weight to 2
- Author Maintainer
@esybrant Does this look good to you?
Collapse replies - Developer
@mlunoe
first_name
andlast_name
are always required. It'sorganization
andcompany_size
that are required/optional depending on the number of users.Customer information fields
- For user count === 1
- Required:
first_name
,last_name
- Optional:
organization
,company_size
- Required:
- For user count > 1
- Required:
first_name
,last_name
,organization
,company_size
,
- Required:
1 - For user count === 1
- Author Maintainer
@esybrant Ah! That makes more sense! Thank you. I have added it to the description
1
- Michael Lunøe added frontend label
added frontend label
- Michael Lunøe changed title from Add form validation of required customer profile form fields to [FE] Add form validation of required customer profile form fields
changed title from Add form validation of required customer profile form fields to [FE] Add form validation of required customer profile form fields
- Michael Lunøe mentioned in epic &5785 (closed)
mentioned in epic &5785 (closed)
- Michael Lunøe added workflowready for development label
added workflowready for development label
- Amanda Rueda changed milestone to %14.2
changed milestone to %14.2
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#2786 (closed)
mentioned in issue gitlab-org/quality/triage-reports#2786 (closed)
- Michael Lunøe changed the description
Compare with previous version changed the description
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#2892 (closed)
mentioned in issue gitlab-org/quality/triage-reports#2892 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#2979 (closed)
mentioned in issue gitlab-org/quality/triage-reports#2979 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3137 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3137 (closed)
- Amanda Rueda added [deprecated] 🍎 label
added [deprecated] 🍎 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3228 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3228 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3300 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3300 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3391 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3391 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3492 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3492 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3566 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3566 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3664 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3664 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3753 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3753 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3850 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3850 (closed)
- Tatyana Golubeva changed milestone to %14.3
changed milestone to %14.3
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#3915 (closed)
mentioned in issue gitlab-org/quality/triage-reports#3915 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4007 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4007 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4016 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4016 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4101 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4101 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4199 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4199 (closed)
- Tatyana Golubeva changed milestone to %14.5
changed milestone to %14.5
- Tatyana Golubeva changed milestone to %14.7
changed milestone to %14.7
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4266 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4266 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4361 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4361 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4428 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4428 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4513 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4513 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4603 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4603 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4670 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4670 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4763 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4763 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4853 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4853 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4942 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4942 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5011 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5011 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5105 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5105 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5172 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5172 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5286 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5286 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5354 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5354 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5420 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5420 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#5467 (closed)
mentioned in issue gitlab-org/quality/triage-reports#5467 (closed)
- Tatyana Golubeva changed milestone to %Next 1-3 releases
changed milestone to %Next 1-3 releases
- Laura Callahan assigned to @lmeckley
assigned to @lmeckley
- Laura Callahan added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Laura Callahan changed milestone to %14.9
changed milestone to %14.9
- Contributor
@mlunoe Should this be blocked by #327859 (closed)?
Collapse replies - Author Maintainer
@lmeckley Yes, it should! Good catch. Added it
- Laura Callahan added workflowrefinement label and removed workflowin dev label
added workflowrefinement label and removed workflowin dev label
- Maintainer
Thanks for working on this @lmeckley! We've removed the Seeking community contributions label to avoid having multiple people working on the same issue.
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Michael Lunøe marked this issue as related to #327859 (closed)
marked this issue as related to #327859 (closed)
- Laura Callahan added workflowblocked label and removed workflowrefinement label
added workflowblocked label and removed workflowrefinement label
- Laura Callahan unassigned @lmeckley
unassigned @lmeckley
- Laura Callahan changed milestone to %Next 1-3 releases
changed milestone to %Next 1-3 releases
- Omar Fernandez added typefeature label
added typefeature label
- 🤖 GitLab Bot 🤖 added [deprecated] low hanging fruit label and removed [deprecated] 🍎 label
added [deprecated] low hanging fruit label and removed [deprecated] 🍎 label
- 🤖 GitLab Bot 🤖 added quick win label and removed [deprecated] low hanging fruit label
added quick win label and removed [deprecated] low hanging fruit label
- Contributor
Hi @gl-docsteam, I'd like to work on this issue. Please assign it to me. Thanks!
Collapse replies - Maintainer
@CBID2 thanks for volunteering! This is a typefeature, rather than a documentation or docs-only issue. If you would still like to work on it, we can ask @ofernandez2 about the assignment.
- Contributor
Sure thanks @dianalogan
- Contributor
Thanks @CBID2! Tagging in the PM/EM for ~"group::purchase" for review here @shreyasagarwal @alex_martin.
- Developer
thanks so much @CBID2!
@shreyasagarwal would love your opinion here but I don't know if this one is quite ready to be worked on as it blocked by this #327859 (closed) body of work which is blocked by several other FE bodies of work, which are then blocked by several BE bodies work.
Edited by Alex Martin 1 - Contributor
Ok thanks
- Alex Martin added 1 deleted label
added 1 deleted label
- Alex Martin added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Sharmad Nachnolkar added groupsubscription management moved-from-purchase-group labels and removed grouppurchase [DEPRECATED] label
added groupsubscription management moved-from-purchase-group labels and removed grouppurchase [DEPRECATED] label
- Tatyana Golubeva changed milestone to %Backlog
changed milestone to %Backlog
- Developer
Closing this issue as closedwill not do . Reference: &5785 (comment 1979666711).
added closedwill not do purchase directionconsolidate labels
- Tatyana Golubeva closed
closed
- 🤖 GitLab Bot 🤖 added Category:Subscription Management label
added Category:Subscription Management label
- Tatyana Golubeva removed workflowblocked label
removed workflowblocked label
- Tatyana Golubeva removed Category:Purchase label
removed Category:Purchase label
- Tatyana Golubeva removed milestone %Backlog
removed milestone %Backlog