Vulnerability-Check approval still required for no new vulnerabilities

Summary

As part of a demo for the https://gitlab.com/gitlab-examples/security/security-reports project we recently tried to update the expectations. This MR is a simple change to the JSON file and according to the MR widget "detected no new vulnerabilities", however approvals are still required. We need to investigate why they were not decremented to zero

Steps to reproduce

(How one can reproduce the issue - this is very important)

Example Project

gitlab-examples/security/security-reports!22 (merged)

What is the current bug behavior?

Vulnerability-Check requires approvals with no new vulnerabilities

What is the expected correct behavior?

Vulnerability-Check requires no approvals with no new vulnerabilities

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited Oct 09, 2019 by Lucas Charles
Assignee Loading
Time tracking Loading