Replace Approval Gate with Status check
This is the frontend implementation issue
Problem to solve
A more generic term was identified to described this feature. Using this terminology will better clarify the action within a merge request, and keep it distinct from approvers.
Proposal
Replace "Approval Gates" with "Status Checks"
Design
Is this a cross-stage feature?
Implementation
frontend estimated weight
- Update strings in
ee/app/assets/javascripts/approvals/components/rule_form.vue
- Remove
approvalGateLabel()
and replace it with the options stringAPI to check
in the template - Update the popover label string in
ee/app/assets/javascripts/approvals/components/approval_gate_icon.vue
- Update the unit tests and feature specs to look for the new strings
Strings to replace:
Old | New |
---|---|
Approvel gate |
Status to check |
Add approval gate |
API to check |
Approval service API |
Status checks |
Follow-up consideration: Refactor component, variable and function names from approvalGate*
to statusChecks*
Edited by Jiaan Louw