Skip to content

Fix cop remaining cop offenses for Style/RegexpLiteralMixedPreserve

Problem

In !58898 (merged) we've introduced a new 👮 Style/RegexpLiteralMixedPreserve.

This MR enabled the 👮 so new offenses are prevented. Current offenses still needs to be fixed. This issue tracks its progress.

Proposed solution

Resolve auto-correctable file by letting RuboCop auto-correct them automatically 🎉

  1. Pick a file from The List below e.g. app/
  2. Create a branch (e.g. rubocop-regexp-literal-mixed-preserve-app)
  3. Delete the files from .rubocop_manual_todo.yml
  4. Let RuboCop auto-correct the offenses via e.g. bundle exec rubocop --auto-correct --only Style/RegexpLiteralMixedPreserve app/
  5. Check changes files and adjust if needed
  6. Commit and create a merge request adding Contributes to #327490 and static code analysis label
  7. Tick off the checkbox(es) and add the MR or mention this merge request in this issue
  8. 🎉

The List

  • app/controllers/projects/repositories_controller.rb
  • app/helpers/ci/variables_helper.rb
  • app/models/alert_management/alert.rb
  • app/models/application_setting.rb
  • app/models/blob_viewer/go_mod.rb
  • app/models/concerns/ci/maskable.rb
  • app/models/operations/feature_flag.rb
  • app/models/packages/go/module.rb
  • app/models/project_services/chat_message/base_message.rb
  • app/services/packages/conan/search_service.rb
  • app/services/projects/update_remote_mirror_service.rb
  • config/initializers/rspec_profiling.rb
  • ee/app/models/status_page/project_setting.rb
  • ee/app/presenters/vulnerability_presenter.rb
  • ee/lib/api/geo_nodes.rb
  • ee/lib/gitlab/vulnerabilities/standard_vulnerability.rb
  • ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb
  • ee/spec/controllers/concerns/routable_actions_spec.rb
  • ee/spec/controllers/groups/groups_controller_spec.rb
  • ee/spec/features/groups/saml_enforcement_spec.rb
  • ee/spec/features/markdown/metrics_spec.rb
  • ee/spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb
  • ee/spec/models/project_services/jira_service_spec.rb
  • ee/spec/services/jira/requests/issues/list_service_spec.rb
  • lib/api/invitations.rb
  • lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb
  • lib/gitlab/metrics/requests_rack_middleware.rb
  • lib/gitlab/metrics/subscribers/active_record.rb
  • lib/gitlab/regex.rb
  • lib/gitlab/utils.rb
  • lib/product_analytics/tracker.rb
  • qa/qa/page/project/settings/advanced.rb
  • qa/spec/service/docker_run/gitlab_runner_spec.rb
  • rubocop/cop/gitlab/duplicate_spec_location.rb
  • spec/features/clusters/cluster_health_dashboard_spec.rb
  • spec/features/markdown/metrics_spec.rb
  • spec/features/search/user_searches_for_code_spec.rb
  • spec/features/snippets/embedded_snippet_spec.rb
  • spec/helpers/diff_helper_spec.rb
  • spec/helpers/releases_helper_spec.rb
  • spec/lib/gitlab/ci/reports/test_case_spec.rb
  • spec/lib/gitlab/consul/internal_spec.rb
  • spec/lib/gitlab/import_export/shared_spec.rb
  • spec/lib/gitlab/utils/usage_data_spec.rb
  • spec/presenters/ci/build_runner_presenter_spec.rb
  • spec/requests/api/projects_spec.rb
  • spec/services/jira/requests/projects/list_service_spec.rb
  • spec/support/capybara.rb
  • spec/support/helpers/grafana_api_helpers.rb
  • spec/support/helpers/query_recorder.rb
  • spec/support/helpers/require_migration.rb
  • spec/support/shared_examples/models/slack_mattermost_notifications_shared_examples.rb
  • spec/views/layouts/_head.html.haml_spec.rb
Edited by Doug Stull