Refactor UrlHelper in project integration settings
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
We should create Presenter logic to handle the help rendering currently contained in the models within /app/models/integrations/. Here is a list of the models which need to be updated (however all files should be checked as the list may have changed since the time of writing this):
- app/models/integrations/campfire.rb
- app/models/integrations/bamboo.rb
- app/models/integrations/asana.rb
- app/models/integrations/buzilla.rb
- app/models/integrations/confluence.rb
- app/models/integrations/custom_issue_tracker.rb
- app/models/integrations/discord.rb
- app/models/integrations/ewm.rb
- app/models/integrations/external_wiki.rb
- app/models/integrations/flowdock.rb
- app/models/integrations/hangouts_chat.rb
- app/models/integrations/jenkins.rb
- app/models/integrations/mattermost.rb
- app/models/integrations/pivotaltracker.rb
- app/models/integrations/redmine.rb
- app/models/integrations/webex_teams.rb
- app/models/integrations/youtrack.rb
The following discussion from !58842 (merged) should be addressed:
-
@minac started a discussion: (+3 comments) suggestion: I am not familiar with this part of the application and don't know if you already have a plan to refactor these models but could you please extract this logic to somewhere else or create/point-out a follow-up issue to refactor the models? IMHO an ActiveRecord model shouldn't be responsible for the presentation layer logic.