Extract allowlist logic to its own class
Why are we doing this work
Enhance maintainability of the respective code base: https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning
Relevant links
Code base: https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning
Suggested location for the new class: https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning/-/tree/master/lib/gcs
Main location of the existing logic:
- https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning/-/blob/master/lib/gcs/cli.rb#L17
- https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning/-/blob/master/lib/gcs/environment.rb#L26
- https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning/-/blob/master/lib/gcs/util.rb
- And their respective specs
Non-functional requirements
-
Testing:
Implementation plan
-
Extract allow list logic into its own class following the resources listed above