Stop changing the vuex value outside vuex for state.approvals.settings
The following discussion from !57844 (merged) should be addressed:
-
@nmezzopera started a discussion: (+1 comment) question: I know that this is the pattern of this file but... I think we are changing the vuex value outside vuex here
😕 This is probably not picked up by the devtools/linters because is a child property but it looks like that settings come straight from vuex:settings: (state) => state.approvals.settings
And the v-model on the approval-settings-checkbox is going to change the value of
preventAuthorApproval
in vuex through the reference chain.This is not correct, do you think we can kick off a followup issue to address this?
Edited by Dan Jensen