Feature::InvalidFeatureFlagError for `prometheus_metrics_measure_*_cpu_duration`
Problem
Folks are starting to see errors like
The feature flag YAML definition for 'prometheus_metrics_measure_banzai_cacheless_render_cpu_duration' does not exist
on local envs.
There are also some failure on staging: https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/2553571
Proposed solution
- Add missing feature flag configuration for
prometheus_metrics_measure_*_cpu_duration.
Gitlab::Metrics.measure(:repository_archive_clean_up) doGitlab::Metrics.measure(:import_export_clean_up) doGitlab::Metrics.measure(:banzai_cached_render) doGitlab::Metrics.measure(:banzai_cacheless_render) doGitlab::Metrics.measure(:increment_pushes_since_gc) doGitlab::Metrics.measure(:reset_pushes_since_gc) doGitlab::Metrics.measure(:obtain_housekeeping_lease) doGitlab::Metrics.measure(:geo_increment_syncs_since_gc) doGitlab::Metrics.measure(:geo_reset_syncs_since_gc) doGitlab::Metrics.measure(:geo_obtain_housekeeping_lease) do
- Enable Prometheus metrics for
gitlab_*_cpu_durationby removingwith_feature "prometheus_metrics
Workaround
@dftian I can get around it by commenting out
with_feature "prometheus_metrics_measure_#{name}_cpu_duration" in lib/gitlab/metrics.rb?.
Related
Edited by Peter Leitzen
