Flash is being used with correct arguments

This issue was realized when the Flash component was used with the incorrect arguments. Perhaps we can add some check or tests to ensure at least the proper parameter types are being used?

Here is the discussion from the a code review where this problem occurred:

I can see Flash is used elsewhere in this file in almost exactly the same way, but I'm not sure the parameters match the signature. The second argument should either be a type string, or undefined (so that the default kicks in), and the third argument should be an Element or Document, not a jQuery instance.

image

Edited Sep 23, 2019 by Samantha Ming
Assignee Loading
Time tracking Loading