Delete group approval rules via API
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Why are we doing this work
To support the management of MR approval rules at the group level, we need to add a create endpoint for the front-end app.
Relevant links
Functional requirements
- Add a new endpoint
DELETE /api/:version/groups/:id/approval_rules/:approval_rule_id - Restrict access to user who has permission to
admin_merge_request_approval_settings - Restrict to only the top-level group
Non-functional requirements
- [-] Documentation: Not needed as it is behind a feature flag
-
Feature flag: group_merge_request_approval_settings_feature_flag - [-] Performance:
-
Testing: Verify new endpoint is added and functional
Implementation plan
-
backend Add new route to the API class API::GroupApprovalRules. -
backend Create a new service class for destroying ApprovalRules::GroupRuleDestroyService
graph LR
API::GroupApprovalRules --> ApprovalRules::GroupRuleDestroyService --> ApprovalGroupRule
Edited by 🤖 GitLab Bot 🤖