Dark mode: Light colored labels are hard to read
Summary
The text on a label is hard to read in dark mode when the label color is fairly light because the label uses white text.
Steps to reproduce
Switch to dark mode. Look at a label with a light background color (e.g. https://gitlab.com/gitlab-org/gitlab/-/issues?label_name[]=popular%20proposal) and go to an issue. Notice the labels in the right bar are now hard to read while its label on the search page were easier to read.
Example Project
What is the current bug behavior?
If a label has a background color assigned that is fairly light (e.g. yellow/orange/pinkish/etc.), then the text for the label when it is shown in the issue sidebar becomes very difficult to read when in dark mode because the text is white.
Note the "Accepting Merge Requests," "Needs Investigation," "Feature," and the first half of the "Section" scoped label in this screenshot:
From the sidebar for issue #14531 (closed), two labels are completely washed out:
What is the expected correct behavior?
The text of the label should be darker (e.g. black) when the label is a light color and white when the label is a dark color.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)