Skip to content

DAST On-Demand: Move DAST site validation to runner

Problem to Solve

When a user saves a url, the built-in url validation prohibits the saving of any url that resolves to a non-routable address as documented by users, #270751 (closed). This is done as a security measure so that the monolith does not access a non-routable url.

Solution

  1. Move the domain validation work to a runner. By moving the validation to a runner, the runner can validate a domain regardless of whether that domain resolves to an internal ip or an external ip.

  2. Once the domain validation is done exclusively on the runner, and monolith/sidekiq no longer visit domains from their trusted servers, the domain validation should be removed from the model.

The validation error exposed in #270751 (closed), will auto-resolve.

Implementation

Edited by Philip Cunningham