Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,763
    • Issues 44,763
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,328
    • Merge requests 1,328
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #324990
Closed
Open
Issue created Mar 16, 2021 by Philip Cunningham@philipcunninghamDeveloper8 of 8 checklist items completed8/8 checklist items

DAST On-Demand: Move DAST site validation to runner

Problem to Solve

When a user saves a url, the built-in url validation prohibits the saving of any url that resolves to a non-routable address as documented by users, #270751 (closed). This is done as a security measure so that the monolith does not access a non-routable url.

Solution

  1. Move the domain validation work to a runner. By moving the validation to a runner, the runner can validate a domain regardless of whether that domain resolves to an internal ip or an external ip.

  2. Once the domain validation is done exclusively on the runner, and monolith/sidekiq no longer visit domains from their trusted servers, the domain validation should be removed from the model.

The validation error exposed in #270751 (closed), will auto-resolve.

Implementation

  • Add feature flag (:dast_runner_site_validation) !61649 (merged)
  • Add internal API !61649 (merged)
  • Add container for validation gitlab-org/security-products/dast-runner-validation!1 (merged)
  • Release container https://gitlab.com/security-products/dast-runner-validation/container_registry
  • Add validation strategy to the monolith behind feature flag !65794 (merged)
  • Add new ci_pipelines.source for validation (e.g. ondemand_dast_validation) !66991 (merged)
  • Add documentation
  • Add support for offline environments by updating Secure-Binaries.gitlab-ci.yml (documentation on how this works https://docs.gitlab.com/ee/user/application_security/offline_deployments/) !66501 (merged)
Edited Aug 02, 2021 by Philip Cunningham
Assignee
Assign to
Time tracking