Remove application code related with Vulnerabilities::Feedback
Why are we doing this work?
Once #324893 (closed) is done we will have no need for the Vulnerabilties::Feedback
model and we should remove it.
Make sure to follow Dropping a database table in case the procedure changes and the implementation plan is stale.
Implementation plan
-
backend Remove
Vulnerabilities::Feedback
model - backend Remove all related controllers
- backend Remove all service object paths
-
backend Remove the
IngestIssueLinks
ingestion task as it will be redundant after !106889 (merged) is merged - backend Remove feedback related code from https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/create.rb
-
backend Remove feedback related code from
ee/app/services/vulnerabilities/
-
backend Remove feedback related code from
ee/app/models/security/finding.rb
-
backend Update
security_findings
method fromhttps://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/finders/security/pure_findings_finder.rb#L34
by removingwith_feedbacks
scope -
backend Remove
Projects::VulnerabilityFeedbackController
index action (make surehttps://gitlab.com/gitlab-org/gitlab/-/issues/390281
is done) - backend Ensure no specs are broken
Edited by Subashis Chakraborty