Unable to add groups as MR approvers even if the group is a direct project member

Summary

Since the introduction of When selecting approvers show only possible users and groups in Update approvers dropdown to use new endpoint merge request users are unable to select groups as Merge Request approvers even if the group is a direct project member.

We are now only able to add only parent groups for the project as Merge Request reviewers.

Steps to reproduce

  1. Create a project
  2. Create a group that is not under the same parent namespace as the project
  3. Add the group as a direct member under the project.
  4. Try selecting the group that is a member of the project as Merge Request reviewer.

Example Project

What is the current bug behavior?

The group is not visible in the drop down. image

What is the expected correct behavior?

The group that is a member of the project should be available in the list of available merge request approvers.

Relevant logs and/or screenshots

image

This bug happens only on Gitlab.com right now.

Possible fixes

NA

Edited by Kate Grechishkina