Approvals displaying '0 of 0' for Merge Requests list view
Summary
When a Merge Request requiring approval has been submitted, Approvals display as '0 of 0' on the Merge Requests list view. When opening the merge request, the approvals are displayed correctly.
Steps to reproduce
- Create a test project
- Add Merge Request Approvers under Settings > General > Merge Request Approvals (in my tests the issue occurred when adding individual members as well as groups)
- Create a merge request
- See approvals displayed on the Merge Request listing (confirm bug behavior) (see screenshot)
- Open the MR to confirm the approvals are displaying correctly
What is the current bug behavior?
On the Merge Request list view, the approvals for a merge request displays "0 of 0" instead of the correct numbers.
What is the expected correct behavior?
On the Merge Request list view, the correct numbers are shown for approvals
Relevant logs and/or screenshots
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 18.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.22.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 12.2.5-ee Revision: e817f2e2864 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.7 URL: https://chrisn-gltest.nightingale.co.za HTTP Clone URL: https://chrisn-gltest.nightingale.co.za/some-group/some-project.git SSH Clone URL: git@chrisn-gltest.nightingale.co.za:some-group/some-project.git Elasticsearch: yes Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 48/1 ... yes 48/2 ... yes 48/3 ... yes 48/4 ... yes 49/5 ... yes 49/6 ... yes 49/7 ... yes 50/8 ... yes 50/9 ... yes 50/10 ... yes 51/11 ... yes 51/12 ... yes 51/13 ... yes 51/14 ... yes 51/15 ... yes 51/16 ... yes 51/17 ... yes 52/18 ... yes 52/19 ... yes 52/20 ... yes 52/21 ... yes 53/22 ... yes 53/23 ... yes 53/24 ... yes 53/25 ... yes 53/26 ... yes 53/27 ... yes 53/28 ... yes 54/29 ... yes 54/30 ... yes 54/31 ... yes 54/32 ... yes 55/33 ... yes 55/34 ... yes 55/35 ... yes 55/36 ... yes 55/37 ... yes 55/38 ... yes 56/39 ... yes 56/40 ... yes 56/41 ... yes 57/42 ... yes 57/43 ... yes 57/44 ... yes 57/45 ... yes 58/46 ... yes 58/47 ... yes 58/48 ... yes 58/49 ... yes 58/50 ... yes 58/51 ... yes 58/52 ... yes 58/53 ... yes 59/54 ... yes 59/55 ... yes 59/56 ... yes 59/57 ... yes 59/58 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.22.0 ? ... yes (2.22.0) Git user has default SSH configuration? ... yes Active users: ... 47 Elasticsearch version 5.6 - 6.x? ... yes (6.8.3)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished

