Merge Trains should allow non-interruptible jobs to complete

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Work on this issue
• Close this issue

Summary

Merge trains can lead to jobs being cancelled immediately, even if they're not marked as interruptible. This can lead to corruption e.g. with terraform jobs that store state elsewhere.

Steps to reproduce

1. Construct a pipeline with a step using something stateful, e.g. terraform
2. Start merge trains for branch A and branch B
3. If the merge train for branch A fails, branch B's pipeline is immediately cancelled and restarted.
4. If B was in the middle of a terraform job, this can lead to lost state.

Example Project

What is the current bug behavior?

Jobs are cancelled immediately

What is the expected correct behavior?

Merge trains should respect the existing "interruptible" flag and allow all jobs to complete.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)
(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)
(we will only investigate if the tests are passing)

Possible fixes