Multiple migration failures
Some of the failing jobs from two different MRs, !55532 (merged) and !54885 (merged):
- https://gitlab.com/gitlab-org/gitlab/-/jobs/1070276704
- https://gitlab.com/gitlab-org/gitlab/-/jobs/1070276707
- https://gitlab.com/gitlab-org/gitlab/-/jobs/1070224476
- Master with https://gitlab.com/gitlab-org/gitlab/-/pipelines/264819045/failures
1) Gitlab::BackgroundMigration::MigrateApproverToApprovalRules sync approval rule and its members merge request behaves like sync approval member when member in old schema but not in new schema creates in new schema
Failure/Error: normalized_repository_storage_weights.max_by { |_, weight| rand**(1.0 / weight) }.first
NoMethodError:
undefined method `first' for nil:NilClass
Shared Example Group: "sync approval member" called from ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:132
# ./app/models/application_setting_implementation.rb:345:in `pick_repository_storage'
# ./lib/gitlab/current_settings.rb:28:in `method_missing'
# ./app/models/repository.rb:1130:in `pick_storage_shard'
# ./app/models/project.rb:78:in `block in <class:Project>'
# ./app/models/project.rb:814:in `initialize'
# ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:121:in `block (4 levels) in <top (required)>'
# ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:18:in `create_member_in'
# ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:43:in `block (5 levels) in <top (required)>'
# ./spec/spec_helper.rb:323:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:314:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:310:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:310:in `block (2 levels) in <top (required)>'
# ./spec/support/database_cleaner.rb:60:in `block (2 levels) in <top (required)>'
2) Gitlab::BackgroundMigration::MigrateApproverToApprovalRules sync approval rule and its members merge request behaves like sync approval member when member in old schema but not in new schema when rule is not created yet creates rule in new schema
Failure/Error: normalized_repository_storage_weights.max_by { |_, weight| rand**(1.0 / weight) }.first
NoMethodError:
undefined method `first' for nil:NilClass
Shared Example Group: "sync approval member" called from ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:132
# ./app/models/application_setting_implementation.rb:345:in `pick_repository_storage'
# ./lib/gitlab/current_settings.rb:28:in `method_missing'
# ./app/models/repository.rb:1130:in `pick_storage_shard'
# ./app/models/project.rb:78:in `block in <class:Project>'
# ./app/models/project.rb:814:in `initialize'
# ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:121:in `block (4 levels) in <top (required)>'
# ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:18:in `create_member_in'
# ./ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb:43:in `block (5 levels) in <top (required)>'
# ./spec/spec_helper.rb:323:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:314:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:310:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:310:in `block (2 levels) in <top (required)>'
# ./spec/support/database_cleaner.rb:60:in `block (2 levels) in <top (required)>'
Edited by Kyle Wiebers