Skip to content

Geo: Self Service Framework - Verify LFS Objects

Background

With &1817 (closed) complete, we need to add verification for the other blob types! This issue is for adding it to LFS objects.

Definition of Done

  • LFS objects blobs are verified
  • Verification for LFS objects is enabled and tested on staging
  • An issue is filed to coordinate the feature flag release

Procedure

Loosely From @mkozono on &5285 (comment 495424992)

  1. Add primary-side verification fields to LFS object model table
  2. Add secondary-side verification fields to LFS object registry table
  3. Return the status of Feature.enabled?(:geo_lfs_object_verification), from self.verification_feature_flag_enabled? for LFS object replicator
  4. Add to LFS object registry classes:
    include ::Gitlab::Geo::VerificationState
    include ::Geo::VerifiableRegistry
  5. Test verification
  6. Enable on staging, test with GitLab Environment Toolkit
  7. Remove FF geo_lfs_object_verification
Edited by Aakriti Gupta