Geo: Self Service Framework - Verify Merge request Diffs
Background
With &1817 (closed) complete, we need to add verification for the other blob types! This issue is for adding it to Merge request Diffs.
Definition of Done
-
Merge request diff blobs are verified -
Verification for Merge request diff is enabled and tested on staging -
An issue is filed to coordinate the feature flag release
Procedure
Loosely From @mkozono on &5285 (comment 495424992)
- Add primary-side verification fields to merge request diff details model table
- Add secondary-side verification fields to merge request diff registry table
- Return the status of
Feature.enabled?(:geo_merge_request_diff_verification)
, from self.verification_feature_flag_enabled? for merge request diff replicator - Add to merge request diff registry class:
include ::Gitlab::Geo::VerificationState include ::Geo::VerifiableRegistry
- Test verification
- Enable on staging, test with GitLab Environment Toolkit
- Remove FF geo_merge_request_diff_verification
Edited by Michael Kozono