Docs: eligible approvers section regarding groups needs clarification
Problem to solve
Our documentation on Eligible Approvers states, emphasis mine:
A group of users can also be added as approvers. In the future, group approvers may be restricted to only groups with share access to the project.
This is slightly misleading as only users who are direct members of a group will count as approvers and due to an existing bug if users read this and have inherited membership they will think an approval rule wasn't created because the approvers are not displayed to them.
Proposal
I'm not sure of the best way to solve this but it seems editing the sentence highlighted above to say:
A group of users can also be added as approvers, though they will only count as approvers if they have direct membership to the group. In the future, group approvers may be restricted to only groups with share access to the project.
Might suffice to make this clear to users new to approval rules.
Who can address the issue
Other links/references
- ZD: https://gitlab.zendesk.com/agent/tickets/190494 (GitLab Internal)
- #323236 (closed)