Skip to content

Design: Visual indicator that MR should be blocked per coverage config

Problem to solve

As a developer reviewing an MR that decreases test coverage, I want to know if the project is configured Not to allow MRs to decrease test coverage, so I can fix that before merge.

What is this issue?

Design to add an indication to the MR page about when an MR cannot be merged because it is configured not to decrease overall test coverage. This will be first be indicated BUT allow a merge and after the approval workflow is in place merge will NOT be allowed.

Proposal

SEE FIGMA PROTOTYPE

  • If a project is setup to block/warn on test coverage decrease (issue), the merge widget in the Merge Request will:
    • Show the Merge button disabled. Users should not be able to interact with the button.
    • Show a Merge request status message.
    • Show a link to the documentation.
  • Once the user fixes the code coverage issues in the MR, the status and message of the merge widget should be updated accordingly.

Links / References

Edited by Rayana Verissimo