Last file in the file list is hidden by the review bar until you scroll to the bottom of the entire page.

Summary

The Merge Request "review" sticky bottom bar hides the bottom elements in the diff file list.

Steps to reproduce

  1. Open a diff of a merge request that has several changed files.
  2. Start writing a comment and press "Start review". A sticky bottom bar appears.
  3. Resize the window so that the file list on the left overflows.
  4. Scroll to the bottom of the file list. Notice how the last file in the list not visible because it's hidden under the "review" bar.
  5. The last file only appears in the list once you scroll down the entire diff view.

Example Project

What is the current bug behavior?

Last file in the file list is hidden by the review bar until you scroll to the bottom of the entire page.

What is the expected correct behavior?

Last file in the file list is visible when you scroll to the bottom of the file list container.

Relevant logs and/or screenshots

View when scrolled to the bottom of file list container

Screenshot_2021-02-26_at_10.29.52

View when scrolled to the bottom of the entire page.

Screenshot_2021-02-26_at_10.30.12

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

Add a little bit of padding-bottom to the file list container.