[Feature flag] Rollout of usage_data_o_pipeline_authoring_unique_users_pushing_mr_ciconfigfile
What
-
Issue: #287682 (closed)
-
Introduced in: !54707 (merged)
-
Remove the :usage_data_o_pipeline_authoring_unique_users_pushing_mr_ciconfigfile
feature flag ... -
Remove the check in lib/gitlab/usage_data_counters/merge_request_activity_unique_counter.rb
.
Owners
- Team: grouppipeline authoring
- Most appropriate slack channel to reach out to:
#g_pipeline-authoring
- Best individual to reach out to: @furkanayhan
Expectations
What are we expecting to happen?
We are expecting to receive o_pipeline_authoring_unique_users_pushing_mr_ciconfigfile
usage ping to Redis HHL when files including CI config are pushed to a new or existing merge request.
What might happen if this goes wrong?
-
UpdateMergeRequestsWorker
may fail or takes longer. -
NewMergeRequestWorker
may fail or takes longer.
What can we monitor to detect problems with this?
-
UpdateMergeRequestsWorker
, We should not see an increase of "fail" job status => https://log.gprd.gitlab.net/goto/ad3fc816cde0c4327be0a7c7b0d97266 -
UpdateMergeRequestsWorker
, We should not see an increase of duration average => https://log.gprd.gitlab.net/goto/c39fbf7bf67570cea4edafdf09589b40 -
NewMergeRequestWorker
, We should not see an increase of "fail" job status => https://log.gprd.gitlab.net/goto/89785ee9190002bcadbb115413479191 -
NewMergeRequestWorker
, We should not see an increase of duration average => https://log.gprd.gitlab.net/goto/08200dd6117d742f0963bc3de03b7ea0
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-org
/gitlab-com
groups - ...
Roll Out Steps
-
Enable on staging ( /chatops run feature set feature_name true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
mention@sre-oncall
and@release-managers
. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry. Ensure that the feature flag definition YAML file has been removed in the same MR that is removing the feature flag from the code -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab feature_name false
Edited by Furkan Ayhan