Regression on keep latest artifact project setting

Problem

When viewing the project CI/CD settings as non application admin it shows the checkbox Keep artifacts from most recent successful jobs always disabled, saying that "This feature is disabled at the instance level", although the application settings shows that the feature IS enabled.

image

The problem is located in the application settings GraphQL response since we authorize reading application settings to only admins.

image

The frontend uses both:

  • project-level setting in order to draw the checkbox and its status
  • application-level settings in order to enable/disable changes and showing the help text

Fix

Rather than fetching application-level settings from GraphQL we only display the Artifacts section of the project settings if the application setting keep_latest_artifact is enabled. Otherwise we hide the entire section since that setting is the only one in the section today.