Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 54.9k
    • Issues 54.9k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1.5k
    • Merge requests 1.5k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #321653
Closed
Open
Issue created Feb 16, 2021 by Martin Brümmer@mbruemmerDeveloper

Group Maintainers are able to use the Group CI/CD Variables API

Summary

Group Maintainers are able to use the Group CI/CD Variables API. According to our permissions model, this action should be limited to Group Owners. Thus is a critical elevation of user permissions.

Steps to reproduce

curl --request POST --header "PRIVATE-TOKEN: $GROUP_MAINTAINER_TOKEN" "https://gitlab.com/api/v4/groups/$GROUP_ID/variables" --form "key=maintainertest" --form "value=test"

What is the current bug behavior?

Group Maintainers are able to manage Group-level CI/CD variables using the API.

What is the expected correct behavior?

Only Group Owners should be able to manage Group-level CI/CD variables.

Relevant logs and/or screenshots

curl --request POST --header "PRIVATE-TOKEN: $GROUP_MAINTAINER_TOKEN" "https://gitlab.com/api/v4/groups/$GROUP_ID/variables" --form "key=maintainertest" --form "value=test"
{"variable_type":"env_var","key":"maintainertest","value":"test","protected":false,"masked":false}%

expected

curl --request POST --header "PRIVATE-TOKEN: $GROUP_MAINTAINER_TOKEN" "https://gitlab.com/api/v4/groups/$GROUP_ID/variables" --form "key=maintainertest" --form "value=test"
{"message":"403 Forbidden"}

Output of checks

This bug happens on GitLab.com

Assignee
Assign to
Time tracking