E2E tests failure "Merge failed..." when attempt to click "Merge" button on merge request page
Action to take
Once re-architect happens, go back and revise merging behavior and clean up any non-necessary page refresh behavior.
Summary
There are a few E2E tests on merge trains keep failing on Staging passed few days.
The cause was when these tests attempt to "Start merge train" on the merge request (after the MR's pipeline has just succeeded), instead of starting the train as expected it resulted in "Merge failed. Refreshing in 10 seconds to show the updated status..." and thus failed the expectation of the tests.
Steps to reproduce
- Create a project
- Push a merge request
- Visit merge request page
- Wait for MR pipeline to pass/succeed
- Click "Start merge train"
Example Project
Though I don't think this happens everytime or maybe just Staging? I also don't see any further todo item of UI notification of this incident.
What is the current bug behavior?
Instead of starting the train as expected it resulted in "Merge failed. Refreshing in 10 seconds to show the updated status..."
What is the expected correct behavior?
Merge train to starts fine.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)(we will only investigate if the tests are passing)
Possible fixes
Not sure but for now to help tests pass, I'm going to add some retry logics.