Geo: Preflight checks blocked by repository checked status
Problem
When repository checks are enabled, rake gitlab:geo:check_replication_verification_status
reports ERROR - Replication is not up-to-date.
, which blocks gitlab-ctl promotion-preflight-checks
during failover.
Proposal
- Do not print repository checks during
rake gitlab:geo:check_replication_verification_status
- Do not look for 100% complete repository checks during
rake gitlab:geo:check_replication_verification_status
- I think we should also remove it from
rake geo:status
until it is more ready as a Geo feature. If we do this as well, then we can just remove it completely fromGeoNodeStatusCheck
without having to be too careful.
More info
When repository checks are enabled the Geo related screens and commands are showing a different result to the checks on a project.
Under Admin > Projects > You can run a repository check from this page and the result is shown directly next to is as well. Here it shows the check was run and has successfully passed. When viewing the replication status on the Geo side the result is still being shown as never run.
Geo Primary Site - Admin Projects Page
Geo Secondary Site - Admin Geo Replication Page
gitlab-ctl promotion-preflight-checks
Geo Secondary Site - Edited by Michael Kozono