reviewer_ids is ignored when updating via the merge_requests API endpoint

Summary

Gitlab version: Version v13.8.1-ee

When adding reviewers via the merge_requests api endpoint, the request is successful however the reviewers are not added.

Steps to reproduce

request:

❯ curl -H "Content-Type: application/json" -X PUT -d '{"id": 135,"merge_request_iid": 2,"reviewer_ids": [46],"assignee_ids": [46],"title": "overwrite"}' https://<redacted>/api/v4/projects/135/merge_requests/2?private_token=<redacted>

response:

{"id":3966,"iid":2,"project_id":135,"title":"overwrite","description":"","state":"opened","created_at":"2021-02-07T02:18:59.462Z","updated_at":"2021-02-07T13:54:31.365Z","merged_by":null,"merged_at":null,"closed_by":null,"closed_at":null,"target_branch":"master","source_branch":"test-mrs","user_notes_count":0,"upvotes":0,"downvotes":0,"author":{"id":33,"name":"mhuber","username":"mhuber","state":"active","avatar_url":"https://<redacted>/uploads/-/system/user/avatar/33/avatar.png","web_url":"https://<redacted>/mhuber"},"assignees":[{"id":46,"name":"Gitlab Integrations","username":"gitlab-integrations","state":"active","avatar_url":"https://secure.gravatar.com/avatar/4d91e53477b801814d1ed5fcd97a2a54?s=80\u0026d=identicon","web_url":"https://<redacted>/gitlab-integrations"}],"assignee":{"id":46,"name":"Gitlab Integrations","username":"gitlab-integrations","state":"active","avatar_url":"https://secure.gravatar.com/avatar/4d91e53477b801814d1ed5fcd97a2a54?s=80\u0026d=identicon","web_url":"https://<redacted>/gitlab-integrations"},"reviewers":[],"source_project_id":135,"target_project_id":135,"labels":[],"work_in_progress":false,"milestone":null,"merge_when_pipeline_succeeds":false,"merge_status":"can_be_merged","sha":"9df6cd91b8e0049c869ecc10d66d954a57b28d29","merge_commit_sha":null,"squash_commit_sha":null,"discussion_locked":null,"should_remove_source_branch":null,"force_remove_source_branch":true,"reference":"!2","references":{"short":"!2","relative":"!2","full":"engineering/infrastructure/yoda!2"},"web_url":"https://<redacted>/engineering/infrastructure/yoda/-/merge_requests/2","time_stats":{"time_estimate":0,"total_time_spent":0,"human_time_estimate":null,"human_total_time_spent":null},"squash":false,"task_completion_status":{"count":0,"completed_count":0},"has_conflicts":false,"blocking_discussions_resolved":true,"approvals_before_merge":null,"subscribed":true,"changes_count":"1","latest_build_started_at":null,"latest_build_finished_at":null,"first_deployed_to_production_at":null,"pipeline":null,"head_pipeline":null,"diff_refs":{"base_sha":"bb5623bf68f3436967e7945a4108eeef1bbfbe02","head_sha":"9df6cd91b8e0049c869ecc10d66d954a57b28d29","start_sha":"1cc9d32c63afb75f8a63128921a2c2da4a112058"},"merge_error":null,"user":{"can_merge":true}}%

What is the current bug behavior?

  • the merge_requests api endpoint is called with valid userids in the reviewer_ids field.
  • the api returns successfully, however, the ids are not added as reviewers

What is the expected correct behavior?

  • the merge_requests api endpoint is called with valid userids in the reviewer_ids field.
  • the api returns successfully and the ids in the reviewer_ids field are added as reviewers

Relevant logs and/or screenshots

image

Results of GitLab environment info

Gitlab version: Version v13.8.1-ee