Remove `except` from blacklist of `CodeReuse/ActiveRecord`

The following discussion from !16508 (merged) should be addressed:

• @dzaporozhets started a discussion: (+2 comments)

  I don't understand why we disallow use of except method in controller. Its ActionController::Parameters method and makes total sense to use in controllers. I believe we should adjust the cop rule.

  I think its too many occurrences and it would be better if we remove except from blacklist, like we did for first, last etc. I don't see a point in rule if we are putting so many ignore places.

mentioned in merge request !16508 (merged)

changed the description

Hi @splattael,

Please add labels to your issue, this aids categorization and locating issues in the future.

Thanks for your help!

---

You are welcome to help improve this comment.

added auto updated label

changed title from Follow-up from "Call NotifyService from NotificationsController" to {+Remove except from blacklist of CodeReuse/ActiveRecord+}

mentioned in merge request !16441 (merged)

I think it would be worth to mention that for our recent usage of except method, that Cop doesn't seem to do the right job. So we are looking at that problem from our angle only.

Here is one more example !16441 (comment 217289285)

But it could be useful in some other context.

I suppose the reasons are described here https://gitlab.com/gitlab-org/gitlab-ce/issues/49653

This is due to Ruby's dynamically typed nature. When RuboCop sees .except(...) it can not determine if it is dealing with ActiveRecord, or something else. Since allowing except does not do any harm, removing it from the blacklist will be fine.

changed milestone to %Backlog

added backstage [DEPRECATED] label

mentioned in merge request !16955 (merged)

Merged via !16955 (merged).

Closing.

closed