"Remove source branch" checkbox doesn't work as expected

Reporduction Steps:

1. Open merge request (remove source branch not selected)
2. Select in GUI checkbox "remove source branch"
3. Send API request --> curl -X PUT -H Privatetoken:TOKEN url/api/v4/projects/id/merge_requests/merge_id/merge
4. Merge merge request succeed
5. In our case the source branch remain not deleted.

mentioned in issue #31864 (closed)

mentioned in issue #32017 (closed)

mentioned in issue #32111 (closed)

added DogfoodingBuild in GitLab devopscreate groupsource code labels

added severity3 typebug labels and removed DogfoodingBuild in GitLab label

marked #32221 (closed) as a duplicate of this issue

mentioned in issue #32221 (closed)

added merge requests label

mentioned in issue #32508 (closed)

Hi, Do we have any update for this issue?

Thanks for the report @manjupri . The checkbox on the merge request display is intended to modify the action of the "merge" button on that page only.

If you "Edit" the merge request, you'll see there's a checkbox there which will take effect globally - including in the API. You can also pass the desired action along in the API call itself, overriding that global setting.

The UI for this could definitely be improved to make it less confusing though, so let's keep this issue open.

added UX frontend priority3 labels

mentioned in issue #32981 (closed)

mentioned in issue #33508 (closed)

mentioned in issue #33965 (closed)

changed milestone to %Awaiting further demand

Pinging @pedroms for feedback on this. I agree with @nick.thomas. Doesn't seem like a strict bug, but we can make this a bit more clear in the UI.

added [deprecated] Accepting merge requests label

@jramsay - I think this might belong in your group - https://gitlab.my.salesforce.com/00161000005cxCt Would like to get an update on when this might be addressed. Their management is looking for timeline on when they can be fixed or not fixed so that they can communicate to their customers internally and take needed action.

@danielgruesso please can you review?

added customer label

added sectiondev label

Setting label(s) Category:Source Code Management based on groupsource code.

added Category:Source Code Management label

added Category:Code Review Workflow groupcode review labels and removed Category:Source Code Management groupsource code labels

Priority label mismatch detected for Merge Request related bug. Applying adjusted priority as per merge request experience prioritization guidelines.

added priority2 label and removed priority3 label

added vintage label

added 1 deleted label

mentioned in issue create-stage#13066 (closed)

mentioned in issue create-stage#13076 (closed)

Hi @phikai, i think this can be closed.

If a user edits an MR and ticks Delete source branch when merge request is accepted. the source branch will be deleted after a PUT to /merge. (Confirmed this on gitlab.com)

If a user selects Delete source branch on the merge widget the state doesn't get saved (as expected because those tick boxes are actions to be performed after pressing the Merge button), and then the source branch will not be deleted after a PUT to /merge

WDYT?

That makes sense to me @jay_mccure - it also seems like it's not a common situation. We can always revisit if those toggles should persist over the API if this comes up in the future.

closed