Update URLs in spec/factories to use .test instead of .org
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32259 fixed the immediate failing specs on master, but as pointed out in the discussion bellow, this failure can occure again. We should take of of other places where the issue can potentially occur. Using .test instead of .org sounds like a good step, we can decide then if futher steps are needed
The following discussion from gitlab-ce!32259 should be addressed:
-
@engwan started a discussion: (+1 comment) These are the ones that I see failed in
master. I see that a lot more specs haveWebMock.stub_requestthough.I think those don't fail yet because the generated webhook URLs don't resolve to an IP (These are generated from a sequence in the factory). We should fix those in a future MR.
Maybe an easy fix would be to generate URLs in the factories that have lesser chances of being real domains. I feel like using
stub_full_requestwould be the proper fix though.