Code changes required for integration with a local PlantUML server
MR gitlab-ce!30199 left two issues to be resolved. As they don't relate to documentation, I have raised this issue to have them addressed:
-
plantumlshould be added to the blacklist of group namesThread: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30199#note_194576803
-
plantumlshould be added toTOP_LEVEL_ROUTESin this file:https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/path_regex.rbThread: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30199#note_194620484
Proposed Fix (from this note):
- Make the path
/-/plantuml/so it's explicitly not a group or user path. - Add
plantumlto the-scope in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/config%2Froutes.rb so that we don't try to use it in the application in future. (We can just make it an explicit 404 in the routing.)
Edited by 🤖 GitLab Bot 🤖